fix(plugins): add missing scope-config and missing projects in grafana for argocd#8642
Merged
klesh merged 1 commit intoapache:mainfrom Dec 18, 2025
Merged
fix(plugins): add missing scope-config and missing projects in grafana for argocd#8642klesh merged 1 commit intoapache:mainfrom
klesh merged 1 commit intoapache:mainfrom
Conversation
…a for argocd The scope-config was missing in the initial implementation, which prevent the DORA metrics to be collected. In Grafana, you could not select the projects, so only ALL was available as an option. I also moved the graphs under the correct sections. For the comment in the issue apache#5207 (comment)
dosubot
bot
added
size:L
ayushkmr
approved these changes
Nov 20, 2025
ayushkmr
left a comment
ayushkmr
left a comment
There was a problem hiding this comment.
LGTM
Minor Notes:
- Helper function firstNonEmpty() could be reusable across plugins
Contributor
Author
|
@klesh could you have a look at the PR please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scope-config was missing in the initial implementation, which prevent the DORA metrics to be collected.
In Grafana, you could not select the projects, so only ALL was available as an option. I also moved the graphs under the correct sections.
Does this close any open issues?
For the comment in the issue #5207 (comment)
Screenshots
scope-config
Grafana
Other Information
Used the config from #8639 for dev-containers and it worked without issue.