Introduce hierarchical namespaces into SqlCatalog#591
Conversation
No, I don't think we should allow this. We also disallow this for the REST catalog. |
|
@cccs-eric Thanks for working on this, could you resolve the conflicts and fix the tests? Sorry for the late reply, I was traveling last week and also the Iceberg summit took some attention :) Thanks! |
@Fokko I have been the one delaying this work, I was swamped with other things. It has always been on my to-do list and I now have some time that I can devote. Hopefully it will be enough to carry the football past the goal line. |
c6b5177 to
744c742
Compare
Fokko
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @cccs-eric for working on this 🙌
When comparing the Python implementation of SqlCatalog with the Java implementation (JdbcCatalog), I have noticed some differences that this PR tries to address. In my opinion, we should be able to read from the same catalog database, using both the Java or Python implementations with no impact.
Here is a list of changes proposed by this PR:
.. For example,ns1.ns2.ns3is a valid namespace in Java, but not with the current Python implementation. Identifiers will now have an optional catalog_name, zero or more namespaces and a table_name. For example, an identifier for tablecatalog_name.ns1.ns2.ns3.table_namewill be represented as the following tuple:("catalog_name", "ns1", "ns2", "ns3", "table_name")create_table(),register_table()now supports a table identifier with an optional catalog name.listCLI commandHere is a list of things to do before opening PR:
listCLI command fix is good