Merged
Conversation
It was refreshing on each of the calls. I think the `before_sleep` is the correct hook.
Fokko
commented
Feb 28, 2024
| new_header = dict(TEST_HEADERS) | ||
| new_header["Authorization"] = f"Bearer {new_token}" | ||
|
|
||
| rest_mock.post( |
Contributor
Author
There was a problem hiding this comment.
This mock was never called.
Contributor
There was a problem hiding this comment.
Perhaps this is why I didn't catch it while validating
Contributor
Author
anupam-saini
approved these changes
Feb 28, 2024
Contributor
anupam-saini
left a comment
anupam-saini
left a comment
There was a problem hiding this comment.
Thank you for catching this @Fokko
anupam-saini
approved these changes
Feb 29, 2024
HonahX
approved these changes
Feb 29, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
LGTM! Thanks @Fokko for fixing this and thanks @anupam-saini for reviewing!
himadripal
pushed a commit
to himadripal/iceberg-python
that referenced
this pull request
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was refreshing on each of the calls. I think the
before_sleepis the correct hook.