dep: disallow pydantic 2.12.0 and 2.12.1, update poetry lock to use pydantic 2.12.3#2635
Merged
Fokko merged 2 commits intoapache:mainfrom Oct 20, 2025
Merged
Conversation
Contributor
Author
|
Running CI once for pydantic 2.12.2 and again for 2.12.3 |
kevinjqliu
force-pushed
the
kevinjqliu/update-pydantic-dep
branch
from
181f2c4 to
16abd4c
Compare
Fokko
approved these changes
Oct 20, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Interesting, thanks for fixing this @kevinjqliu. 2.12.1 even got yanked: https://pypi.org/project/pydantic/#history
Xuanwo
pushed a commit
to apache/iceberg-rust
that referenced
this pull request
Oct 28, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> Revert of #1737 pydantic release a fix in 2.12.3 which will be automatically used by resolver (see simliar in pyiceberg, apache/iceberg-python#2635) ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up to #2591
Closes #2590
Pydantic released a regression in 2.12.x that was fixed by 2.12.2 and 2.12.3
2.12.2 originally did not work due to incompatible signature that was fixed in #2626
2.12.3 turn the incompatible signature into a deprecation warning.
This PR disallows pydantic 2.12.0 and 2.12.1 and update poetry lock to use pydantic 2.12.3
With #2626 merged, pyiceberg should work with both pydantic 2.12.2 and 2.12.3
Are these changes tested?
Yes, UT.
Tested both with pydantic 2.12.2 and 2.12.3
Are there any user-facing changes?
No