Merged
Conversation
Fokko
approved these changes
Feb 10, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing this right away!
Fokko
added a commit
that referenced
this pull request
Feb 10, 2025
We just had an issue with merging a stale branch, which fixed @kevinjqliu right away in #1638 In `iceberg-rust` they have this nice button: <img width="920" alt="image" src="https://github.com/user-attachments/assets/194fef4a-89aa-407c-a113-4253fc5ad04b" /> I think this is the result of the following config: https://github.com/apache/iceberg-rust/blob/63545895d2c35db0f0c550cb1c08acd52a9f5b4c/.asf.yaml#L36C10-L39C21 I don't think it would work well for Java because of the activity there, and the time it takes to run the Spark integration tests, but I would love to have this button here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is failing on main branch
https://github.com/apache/iceberg-python/actions/runs/13247077313/job/36976096982
Caused by merge conflict after #1140.
InMemoryCatalognow does not automatically create the namespace.