Skip to content

Comments

1191:Added Docstring and Fixed linter error #1590

Closed
gayatrikate04 wants to merge 8 commits intoapache:mainfrom
gayatrikate04:docstring-added/1191
Closed

1191:Added Docstring and Fixed linter error #1590
gayatrikate04 wants to merge 8 commits intoapache:mainfrom
gayatrikate04:docstring-added/1191

Conversation

@gayatrikate04
Copy link

@gayatrikate04 gayatrikate04 commented Jan 29, 2025

This pull request updates the docstrings and fixes the linter errors that were identified in the previous PR (#1533)

Changes:
Updated docstrings for improved documentation and readability.
Fixed linter issues as per feedback from PR #1533.

@gayatrikate04 gayatrikate04 changed the title Fixed linter error 1191:Added Docstring and Fixed linter error Jan 29, 2025
@kevinjqliu
Copy link
Contributor

Hi @gayatrikate04 since this is the same set of changes as #1533, can we reuse #1533?

@gayatrikate04
Copy link
Author

gayatrikate04 commented Jan 30, 2025

Hi @kevinjqliu , thank you for pointing that out! I created a new PR (#1590) instead of merging into the old PR (#1533) because I encountered errors while trying to merge changes into the old PR branch. To avoid further complications, I decided to start fresh with a new branch and this PR.

@kevinjqliu
Copy link
Contributor

hey @gayatrikate04 looks like theres are changes that added mkdocs = "^1.6.1" as a dependency. I dont think its necessary for documentation related changes, can you remove those?

@gayatrikate04
Copy link
Author

I've removed the mkdocs = "^1.6.1" dependency

@kevinjqliu
Copy link
Contributor

duplicate of #1533

@kevinjqliu kevinjqliu closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants