Conversation
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for adding this! I was thinking of the same thing.
| * under the License. | ||
| */ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
nit: add the \file docstring and mention that it is adapted from Apache Arrow.
There was a problem hiding this comment.
Will add later today, thanks for the suggestion.
There was a problem hiding this comment.
If we take big pieces from other projects, then we also want to add that to the LICENSE:
For example in PyIceberg: https://github.com/apache/iceberg-python/blob/260ef54e3920d435ae3b2ccda090e66f9c1ac015/LICENSE#L206-L213
There was a problem hiding this comment.
Sounds good, let's include that in both the LICENSE and NOTICE.
Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
The visit type infrastructure is adapted from apache arrow. Add a reference note per @lidavidm's suggestion. Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
The community has reached a consensus. Let's move!
5 participants
Add a
TypeIdfield to each concrete type to enable macro-based type visitor support.