refactor: simplify library management#52
Merged
Fokko merged 1 commit intoapache:mainfrom Mar 27, 2025
Merged
Conversation
Libraries are consolidated to libiceberg and libiceberg-bundle
Member
Author
|
FTR, current install directory on my MacOS looks like |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the library management by consolidating the libraries into libiceberg and libiceberg-bundle, and updates the corresponding build instructions.
- Updated the section title in the README from "Build and Install Iceberg Arrow Library" to "Build and Install Iceberg Bundle Library".
- Adjusted the CMake flags: replacing ICEBERG_ARROW with ICEBERG_BUILD_BUNDLE for both vendored and provided Apache Arrow configurations.
Files not reviewed (18)
- CMakeLists.txt: Language not supported
- cmake_modules/IcebergThirdpartyToolchain.cmake: Language not supported
- example/CMakeLists.txt: Language not supported
- example/demo_example.cc: Language not supported
- src/iceberg/CMakeLists.txt: Language not supported
- src/iceberg/IcebergConfig.cmake.in: Language not supported
- src/iceberg/arrow/CMakeLists.txt: Language not supported
- src/iceberg/arrow/demo_arrow.h: Language not supported
- src/iceberg/avro/CMakeLists.txt: Language not supported
- src/iceberg/avro/demo_avro.h: Language not supported
- src/iceberg/demo.cc: Language not supported
- src/iceberg/puffin.h: Language not supported
- src/iceberg/puffin/CMakeLists.txt: Language not supported
- src/iceberg/puffin/demo_puffin.cc: Language not supported
- src/iceberg/puffin/demo_puffin.h: Language not supported
- src/iceberg/util/CMakeLists.txt: Language not supported
- test/CMakeLists.txt: Language not supported
- test/arrow/CMakeLists.txt: Language not supported
lidavidm
approved these changes
Mar 27, 2025
yingcai-cy
reviewed
Mar 27, 2025
Fokko
approved these changes
Mar 27, 2025
Contributor
|
@wgtmac Sure thing, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libraries are consolidated to
libicebergandlibiceberg-bundle