fix: bump avro version to enable uuid type test case#103
Merged
Fokko merged 1 commit intoapache:mainfrom May 21, 2025
Merged
Conversation
lidavidm
approved these changes
May 20, 2025
Contributor
|
lgtm |
yingcai-cy
approved these changes
May 20, 2025
Xuanwo
approved these changes
May 21, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
The community has reached a consensus; let's proceed.
By the way, what's the process of bumping deps? Is it possible to pin on a tag instead of a commit hash?
Member
Author
|
@Xuanwo Thanks for the comment! Ideally it should be downloaded from a released tar ball with checksum verified. However, I have fixed many issues on the avro-cpp side so we have to use a specific commit hash from the main branch before the next 1.13.0 version is released. This is just a transient state to unblock our development. |
Fokko
approved these changes
May 21, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Nice one @wgtmac! 🙌 Thanks @lidavidm, @Xuanwo and @yingcai-cy for the review 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.