Conversation
dev/check-license
Outdated
| exit 1 | ||
| else | ||
| echo -e "RAT checks passed." | ||
| fi No newline at end of file |
There was a problem hiding this comment.
Do we need a empty line in the end here?
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: "Run License Check" |
There was a problem hiding this comment.
Should we consider the apache/skywalking-eyes@main Github action which Apache ORC currently uses: https://github.com/apache/orc/blob/main/.github/workflows/build_and_test.yml#L178-L189
It looks simpler to use IMHO.
There was a problem hiding this comment.
Yes, that looks much simpler indeed. Question, do you know why it needs the Github token?
There was a problem hiding this comment.
It seems required to comment on the PR:
https://github.com/apache/skywalking-eyes/blob/3ea9df11bb3a5a85665377d1fd10c02edecf2c40/pkg/review/header.go#L62-L64
There was a problem hiding this comment.
That's fancy, let me change to Skywalking!
zhjwpku
left a comment
zhjwpku
left a comment
There was a problem hiding this comment.
add a newline to the end of a file.
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
|
Thanks @raulcd @zhjwpku Let's add pre-commit so we can add the yaml format hook to avoid manual formatting of yaml. Machines are much better at that :) Anyone interested in adding that? |
I can give it a look, thanks. |
5 participants
To make sure that we have the right headers 👍