Skip to content

627 introduce fluss sink ds#908

Merged
wuchong merged 12 commits intoapache:mainfrom
polyzos:627-introduce-fluss-sink-ds
Jun 6, 2025
Merged

627 introduce fluss sink ds#908
wuchong merged 12 commits intoapache:mainfrom
polyzos:627-introduce-fluss-sink-ds

Conversation

@polyzos
Copy link
Contributor

@polyzos polyzos commented May 19, 2025 •
edited
Loading

No description provided.

This was referenced May 19, 2025
Closed
Closed
Closed
@polyzos
Copy link
Contributor Author

polyzos commented May 19, 2025

We will support target columns via column names with this.

@polyzos polyzos marked this pull request as ready for review May 20, 2025 06:59
@polyzos
Copy link
Contributor Author

polyzos commented May 20, 2025

@wuchong Please help review to see if there is anything missing here

@polyzos polyzos requested a review from wuchong May 20, 2025 08:15
wuchong
wuchong reviewed Jun 5, 2025
View reviewed changes
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @polyzos , I left some comments.

wuchong
wuchong reviewed Jun 5, 2025
View reviewed changes
fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/sink/FlussSinkBuilder.java Outdated
}

/** Set the row type for the sink. */
public FlussSinkBuilder<InputT> setRowType(RowType rowType) {
Copy link
Member

@wuchong wuchong Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tableRowType can also be retrieved from TableInfo.

Copy link
Contributor Author

@polyzos polyzos Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuchong TableInfo return a Fluss rowType, however the writer constructors require A Flink rowType.. do we have any build-in converters for the row types as well?

@polyzos polyzos force-pushed the 627-introduce-fluss-sink-ds branch 3 times, most recently from 9a8718e to 6c08c13 Compare June 6, 2025 06:41
@polyzos polyzos force-pushed the 627-introduce-fluss-sink-ds branch from 6c08c13 to e718d3c Compare June 6, 2025 06:42
@polyzos
Copy link
Contributor Author

polyzos commented Jun 6, 2025

@wuchong Thank you for your comments. I left one comment and addressed the rest. Let me know if there is anything I missed

wuchong
wuchong approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to improve it a bit. Will merge it once CI is passed.

fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/sink/FlussSinkBuilder.java Outdated
}

/** Set target column indexes. */
public FlussSinkBuilder<InputT> setPartialUpdateColumns(int[] partialUpdateColumns) {
Copy link
Member

@wuchong wuchong Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this method because the builder doesn't currently support partial updates. We can reintroduce it once partial update support to the DataStream API in the future. Since it's a public API, making changes after release will be difficult, so it's better to wait until the feature is ready. Additionally, I think using field names instead of field indexes would be more user-friendly and less error-prone.

Copy link
Contributor Author

@polyzos polyzos Jun 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuchong indeed the goal was to make it work with field names, but we had a separate ticket to track this, here

Copy link
Member

@wuchong wuchong Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polyzos cool!

@wuchong wuchong merged commit 4922bfe into apache:main Jun 6, 2025
4 checks passed
@wuchong wuchong linked an issue Jun 6, 2025 that may be closed by this pull request
Introduce FlussSink for Flink DataStream API #627
Closed
luoyuxia pushed a commit to luoyuxia/fluss that referenced this pull request Jun 11, 2025
@polyzos @luoyuxia
[connector/flink] Introduce DataStream Sink API for Flink (apache#908)
d01dd0d
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
@polyzos @ZmmBigdata
[connector/flink] Introduce DataStream Sink API for Flink (apache#908)
29206da
polyzos added a commit to polyzos/fluss that referenced this pull request Aug 30, 2025
@polyzos
[connector/flink] Introduce DataStream Sink API for Flink (apache#908)
6052642
polyzos added a commit to Alibaba-HZY/fluss that referenced this pull request Aug 31, 2025
@polyzos
[connector/flink] Introduce DataStream Sink API for Flink (apache#908)
33a2981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuchong wuchong wuchong approved these changes

@MehulBatra MehulBatra MehulBatra left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce FlussSink for Flink DataStream API

3 participants

@polyzos @wuchong @MehulBatra