Merged
Conversation
Contributor
Author
|
cc @leekeiabstraction 😄 |
Contributor
|
Thanks for the quick PR 🚀@charlesdong1991 Mostly looks good but just want to check, are these all that were missing? |
Contributor
Author
|
@leekeiabstraction good check, i think config-property-wise it's all covered, but there is one error code of NONE and an unregistered table distribution (seems not in lib.rs), not sure if we want to add it to be available at runtime. now i guess it's misleading for end-users |
luoyuxia
approved these changes
Mar 1, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@charlesdong1991 Thanks. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing python type stubs based on comment #396 (comment)