fix: Fix and Refactor Spark shuffle function#20484
Open
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Open
fix: Fix and Refactor Spark shuffle function#20484erenavsarogullari wants to merge 1 commit intoapache:mainfrom
shuffle function#20484erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Conversation
ca8d43a to
9d26adc
Compare
9d26adc to
11ea3c0
Compare
Jefffrey
reviewed
Feb 23, 2026
Comment on lines
+110
to
+111
| query error DataFusion error: Execution error: shuffle seed must be Int64 type but got 'NULL' | ||
| SELECT shuffle([1, 2, 3], NULL); |
Contributor
There was a problem hiding this comment.
This doesn't actually seem to match spark semantics
>>> spark.sql("select shuffle(array(1,2,3), null)").show()
+-----------------------+
|shuffle(array(1, 2, 3))|
+-----------------------+
| [1, 2, 3]|
+-----------------------+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
shufflefunction #20483.Rationale for this change
Currently, Spark
shufflefunction returns following error message whenseedisnull. This needs to be fixed by exposingNULLinstead of'Int64'.Current:
New:
In addition to this fix, this PR also introduces following refactoring to
shufflefunction:singleerror message,shuffle.rsandshuffle.slt.What changes are included in this PR?
Are these changes tested?
Yes, being added new UT cases.
Are there any user-facing changes?
Yes, updating Spark
shufflefunctions error messages.