fix: SortMergeJoin don't wait for all input before emitting#20482
Draft
rluvaton wants to merge 8 commits intoapache:mainfrom
Draft
fix: SortMergeJoin don't wait for all input before emitting#20482rluvaton wants to merge 8 commits intoapache:mainfrom
rluvaton wants to merge 8 commits intoapache:mainfrom
Conversation
EmilyMatt
reviewed
Feb 22, 2026
| } | ||
|
|
||
| // TODO - NEED TO CHECK IF WE HAVE ENOUGH DATA TO FILL BATCH | ||
| // TODO - WHAT ABOUT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Looks like from playing around with local tests and debugging memory issue I have that
SortMergeJoinStreamwait for all input before start emitting, which shouldn't be the case as we can emit early when we have enough data.also, less memory usage.
What changes are included in this PR?
Trying to fix the issue, not sure yet
Are these changes tested?
Yes
Are there any user-facing changes?
TODO: