Conversation
.github/workflows/rust.yml
Outdated
| linux-build-lib: | ||
| name: linux build test | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m7a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m7a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} |
There was a problem hiding this comment.
this one is quite lightweight, i switched to just 8 cpu and got the same ish time
| linux-build-lib: | ||
| name: linux build test | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m7a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} |
There was a problem hiding this comment.
One thing I was thinking is that someone in the future may run into this and have a hard time understanding what all the runs-on is all about
I didn't see it documented anywhere -- https://github.com/search?q=repo%3Aapache%2Fdatafusion%20runs-on&type=code
Is there any chance that you could write up some documentation in a README that explains why we are using runs-on and how to apply/unapply it?
For example, it might not be obvious without the context of this PR, to know that
runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }}Was the same as
runs-on: ubuntu-latestExcept that in the apache repo it triggers the use of special runners
There was a problem hiding this comment.
Updated docs/source/contributor-guide/index.md and referenced that in CI yml file. Do you think we should also mention that in readme?
There was a problem hiding this comment.
Going to merge this PR now but happy to expand docs further in the follow up in you like 🙂
|
We just got our AWS limits increased to a very high number, so we can now switch all the remaining actions 🙂. In this PR I've switched everything big (>= 4min) except for:
I think overall this change should save us 1 hour of CI time per commit |
Follow up on #20107: switch more actions to the new flow