Remove core dependency from ffi#19422
Merged
timsaucer merged 1 commit intoapache:mainfrom Dec 22, 2025
Merged
Conversation
Member
Author
|
Per your request @kylebarron at long last! |
Member
Author
|
@paleolimbot @renato2099 @comphead Thank you so much for the reviews on this epic! Here is the last PR to reduce build times for our downstream users. |
paleolimbot
approved these changes
Dec 22, 2025
Member
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
Nice...I am excited for this!
These are all just import updates and look good to me!
comphead
approved these changes
Dec 22, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
That is awesome, thanks @timsaucer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #18671
Rationale for this change
With the latest changes for #18671 we no longer require
datafusioncrate as a dependency. This will reduce build times for users. Also it guarantees we do not accidentally introduce code that will create aSessionContextor any other large binary inside our FFI implementations.What changes are included in this PR?
datafusioncrate from Cargo.tomlAre these changes tested?
Existing unit tests.
Are there any user-facing changes?
No. This only updates paths.