Allow unparser to override the alias name for the specific dialect#16540
Merged
alamb merged 3 commits intoapache:mainfrom Jun 25, 2025
Merged
Allow unparser to override the alias name for the specific dialect#16540alamb merged 3 commits intoapache:mainfrom
alamb merged 3 commits intoapache:mainfrom
Conversation
alamb
approved these changes
Jun 24, 2025
|
|
||
| #[test] | ||
| fn roundtrip_statement_with_dialect_special_char_alias() -> Result<(), DataFusionError> { | ||
| roundtrip_statement_with_dialect_helper!( |
Contributor
There was a problem hiding this comment.
it might also help to add a test case here with unparser_dialect GenericDialect too to show the difference in dialects
Contributor
|
🚀 |
Contributor
Author
|
Thanks @alamb 👍 |
goldmedal
added a commit
to Canner/datafusion
that referenced
this pull request
Jul 4, 2025
…pache#16540) * allow override col alias for specific dialect * improve test case * add generic dialect case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No corresponding issue at DataFusion. I encountered it in the Wren AI case.
countsyntax for BigQuery Canner/wren-engine#1089Rationale for this change
Consider the following SQL:
It will be simplified to the following SQL after we move
CountWildcardRuleto the logical planner #14689However, some dialects (e.g. BigQuery) don't allow some special characters(
(,*,@, ...) in an alias name. We should have a way to handle this case for the unparser.What changes are included in this PR?
col_alias_overridesfor the unparser dialect.BigQueryDialect, which will encode the special character in the alias name.Are these changes tested?
Are there any user-facing changes?
new method for the unparser dialect.