feat: Add array_max function support#14470
Conversation
array_max functionarray_max function support
7d76719 to
0dbdbba
Compare
|
FYI @findepi I think you mentioned this feature recently |
69a307e to
222bf3b
Compare
|
I have the same question for |
222bf3b to
48ecaa5
Compare
48ecaa5 to
a48dfaa
Compare
Thanks @jayzhan211 for the review. I think we have 2 use cases for |
fbb4afb to
f29c95c
Compare
Sounds like Spark crate is a great place for this #5600 |
|
Per project guidelines proposal #13706 it feels to me as belong to core. |
5c43600 to
46d8431
Compare
46d8431 to
61ef64c
Compare
|
Merged, thanks! |
* Issue-14469 - feat: Add array_max function * Address review comments * Address review comments II * Address review comments III
Which issue does this PR close?
Closes #14469.
What changes are included in this PR?
Currently, Spark, Snowflake and Presto support
array_maxfunction. This can also be useful for DataFusion.Spark: https://docs.databricks.com/en/sql/language-manual/functions/array_max.html
Snowflake: https://docs.snowflake.com/en/sql-reference/functions/array_max
Presto: https://prestodb.io/docs/current/functions/array.html#array_max-x-x
All potential use-cases have been covered like different
data_types,empty array,NULLetc.Are these changes tested?
Added new UT cases to verify
array_maxfunction in terms of different source arrays.Are there any user-facing changes?
Yes, new SQL function is supported and documentation has also be updated.