GH-49268: [C++][FlightRPC] Fix ODBC tests for MacOS#49267
Open
justing-bq wants to merge 3 commits intoapache:mainfrom
Open
GH-49268: [C++][FlightRPC] Fix ODBC tests for MacOS#49267justing-bq wants to merge 3 commits intoapache:mainfrom
justing-bq wants to merge 3 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
github-actions
bot
added
Component: C++
Component: FlightRPC
CI: Extra: C++
Contributor
Author
justing-bq
changed the title
justing-bq
changed the title
|
|
alinaliBQ
force-pushed
the
fixMacTests
branch
6 times, most recently
from
53d0e44 to
af8035e
Compare
alinaliBQ
reviewed
Mar 11, 2026
| ValidateFetch(stmt, SQL_NO_DATA); | ||
|
|
||
| // Sizes are zeros | ||
| EXPECT_EQ(SQL_SUCCESS, SQLColumns(this->stmt, catalog_name, 0, schema_name, 0, |
Collaborator
There was a problem hiding this comment.
Note to reviewers: many of the PR's changes for removing this->
github-actions
bot
added
awaiting committer review
justing-bq
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
Co-authored-by: justing-bq <justin.gossett@improving.com> Co-authored-by: alinalibq <alina.li@improving.com> Update test files Refactor test setup/teardown to reuse connection across tests * Define Mock Server SetUp/TearDown at Environment level * Refactor test setup/teardown to reuse connection across tests * In-progress fix DSN write issue on macOS without `sudo` * Getting errors of `SQLSetConfigMode` flagged as `void`, ``` error: cannot initialize return object of type 'bool' with an rvalue of type 'void' 502 | ASSERT_TRUE(SQLSetConfigMode(ODBC_BOTH_DSN)); ``` * Clean Up PR * Remove unneeded changes --------- Co-Authored-By: Alina (Xi) Li <alinal@bitquilltech.com>
Put `ODBCINST` before `ODBC_LIBRARIES` in terms of linking. Co-Authored-By: Alina (Xi) Li <alinal@bitquilltech.com>
* Enable disabled tests * Fix getinfo tests to use standalone connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Addresses #49268
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.