ARROW-13397: [R] Update arrow.Rmd vignette#11202
ARROW-13397: [R] Update arrow.Rmd vignette#11202thisisnic wants to merge 3 commits intoapache:masterfrom
Conversation
thisisnic
changed the title
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Looks good, one change / question about the link there
r/vignettes/arrow.Rmd
Outdated
|
|
||
| ^2^: Some Arrow data types do not have an R equivalent and will raise an error | ||
| if cast to or mapped to via a schema. See | ||
| [this discussion section](#no-compat-type) for an example of this. |
There was a problem hiding this comment.
Instead of "See [this discussion section]" could we use something like "See [the XXX section]" (the this to me seems a little bit odd.
Also, where is this supposed to be linking to? I've tried to find the section but haven't yet
There was a problem hiding this comment.
Argh, I'm an idiot, I pasted this back from the cookbook without reading properly, will update!
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
This looks good. One small nit and one question out of curiosity
|
|
||
| ^4^: Due to the limitation of R `factor`s, Arrow `dictionary` values are coerced to string when translated to R if they are not already strings. | ||
| ^4^: Due to the limitation of R factors, Arrow `dictionary` values are coerced | ||
| to string when translated to R if they are not already strings. |
There was a problem hiding this comment.
This isn't relevant in this doc, but now I'm curious: what is the limitation of R factors here?
There was a problem hiding this comment.
Not a clue tbh; I think @ianmcook may(?) have written this text originally, so might have a better idea than me
| yields a `bit64::integer64` vector) by setting `options(arrow.int64_downcast = FALSE)`. | ||
|
|
||
| ^2^: Some Arrow data types do not have an R equivalent and will raise an error | ||
| if cast to or mapped to via a schema. |
There was a problem hiding this comment.
Might we mention something like "do not yet have an R equivalent"? At least for duration I imagine we will map it on to lubridate's duration type at some point?
Update the table in arrow.Rmd to add extra explanations and re-order some of the contents. Closes apache#11202 from thisisnic/ARROW-13397_arrow.Rmd Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
2 participants
Update the table in arrow.Rmd to add extra explanations and re-order some of the contents.