Merged
Conversation
mbutrovich
commented
Mar 31, 2025
Contributor
Author
|
apache/parquet-testing#73 merged so I think this is ready for review. |
alamb
approved these changes
Apr 3, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @mbutrovich -- this is a nice contribution. Testing for the WIN!
| }) | ||
| } | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
It might also be worth a test showing what happens when a schema is not supplied for this file (that the data is read out as nanosecond precision)
alamb
approved these changes
Apr 4, 2025
| let expected = Arc::new(Int64Array::from(vec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We would like to enforce testing on a challenging int96 file generated by Spark with its microsecond timestamps. It is challenging because it includes dates that cannot be represented in a nanosecond timestamp.
What changes are included in this PR?
Add a test that is dependent on apache/parquet-testing#73 merging first.
Are there any user-facing changes?
No.