GH-470: [Vector] Fix ListViewVector.getElementEndIndex(index) method#1019
Open
axreldable wants to merge 2 commits intoapache:mainfrom
Open
GH-470: [Vector] Fix ListViewVector.getElementEndIndex(index) method#1019axreldable wants to merge 2 commits intoapache:mainfrom
axreldable wants to merge 2 commits intoapache:mainfrom
Conversation
…(hashCode) and offsetBuffer with SIZE_WIDTH (setSize) plus refactoring to avoid code duplication in ListViewVector
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Please add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
First commit changes logic:
ListViewVector.getElementEndIndex(index)method .Before:
After:
Second commit doesn't change logic:
Fixes a bug of usage
sizeBufferwithOFFSET_WIDTH(hashCodemethod) andoffsetBufferwithSIZE_WIDTH(setSizemethod). It doesn't introduce real changes in the logic asOFFSET_WIDTH==SIZE_WIDTH== 4Plus small refactoring of ListViewVector to avoid code duplication and similar issues in the future.
It's a bug fix.
Closes #470.