Skip to content

fix(plugins): add translations for query suggestions and recent searches plugins#1283

Merged
Haroenv merged 1 commit intoalgolia:nextfrom
justinedelson:fix/translations-rs-suggestions
Nov 5, 2024
Merged

fix(plugins): add translations for query suggestions and recent searches plugins#1283
Haroenv merged 1 commit intoalgolia:nextfrom
justinedelson:fix/translations-rs-suggestions

Conversation

@justinedelson
Copy link
Copy Markdown
Contributor

Closes #1282

Summary

As discussed in #1282, this PR adds translation configuration for the suggestions and recent searches plugins analogous to what exists in core (although obviously much smaller in scope).

While it is possible to do this via providing entirely custom templates, that is quite heavyweight for just providing translations.

Result

See new unit tests

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Nov 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6365114:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Copy Markdown
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@Haroenv Haroenv merged commit 572cd3c into algolia:next Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

strings in the query-suggestions and recent-searches plugins cannot be translated without replacing entire template

2 participants