add eslint rules for JSX style from issue #345#346
Merged
justjake merged 2 commits intoairbnb:masterfrom May 18, 2015
Merged
Conversation
Member
|
Fine to keep them in the existing If it becomes problem to maintain in the future we could introduce a build tool around this, but that's not necessary at the moment. 👍 thanks @nkt! |
justjake
added a commit
that referenced
this pull request
May 18, 2015
add eslint rules for JSX style from issue #345
Collaborator
Author
|
PS issue is #345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds React style to our
.eslintrc.These rules were authored by @nktShould we keep these rules separate from our base
.eslintrcor is it fine to put them in here?