Add markers to spaced-comment block for Flow types#1966
Merged
ljharb merged 1 commit intoairbnb:masterfrom Aug 10, 2019
Merged
Conversation
Contributor
Author
|
To bump this, and to make it easier to view the original motivation for this PR, I'll link to the page that describes how Flow can work with type declarations inside these comments: https://flow.org/en/docs/types/comments/ |
ljharb
requested changes
Feb 28, 2019
| line: { | ||
| exceptions: ['-', '+'], | ||
| markers: ['=', '!'], // space here to support sprockets directives | ||
| // support sprockets directives |
Collaborator
There was a problem hiding this comment.
please move the comments back to being inline; line length isn't worth worrying about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested in one of my projects - Flow allows a syntax for typing in comments, but these markers have to be added to not throw errors. Flow could do it with a space in between, but it seems like an easy enough style to allow, and a good one to follow.