Open
Conversation
Contributor
Author
|
can't build until ocaml/opam-repository#29421 is merged |
rr0gi
reviewed
Mar 9, 2026
| and poll is guaranteed to be available without the fd limitation. | ||
| *) | ||
| let () = | ||
| if not (Lwt_config._HAVE_LIBEV && Lwt_config.libev_default) then begin |
Contributor
There was a problem hiding this comment.
is this method not available in lwt 6?
rr0gi
reviewed
Mar 9, 2026
Contributor
rr0gi
left a comment
rr0gi
left a comment
There was a problem hiding this comment.
is lwt_engine change required?
| end | ||
| | Lwt_engine.Engine_id__poll -> () | ||
| | lwteng -> | ||
| eprintfn "Unknown Lwt engine (%s) in use, leaving as is" Obj.Extension_constructor.(name (of_val lwteng)); |
Contributor
There was a problem hiding this comment.
i see Obj i suspect
there is no name function to use?
but then anw i would rather emit log for non-default behaviour branch (ie select=>poll) and do not log anything in other branches (ie here)
devkit.opam
Outdated
| "curl_lwt" | ||
| "pcre2" {>= "8.0.3"} | ||
| "trace" {>= "0.4"} | ||
| "trace" {>= "0.10" & < "0.11"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note that bc lwt had some significant changes in version 6, the version after this PR is not compatible with lwt<6. we might want to do something special like keeping a separate branch for lwt<6 support with distinct releases and such. or not? what do you think?