Add support for multiple single elements vld1 instructions#7531
Open
icymanred wants to merge 8 commits intoVector35:devfrom
Open
Add support for multiple single elements vld1 instructions#7531icymanred wants to merge 8 commits intoVector35:devfrom
icymanred wants to merge 8 commits intoVector35:devfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the multiple single elements variant of the VLD1 instruction in ARMv7 architecture. The changes include utility functions for handling register lists and data type size calculations, along with the implementation of VLD1 instruction lifting to LLIL.
Key changes:
- Added
GetDataTypeSizefunction to convert data type enums to bit sizes - Added
ReadRegisterListfunction to parse register list operands using platform-specific intrinsics - Implemented VLD1 instruction handling with proper register list iteration and memory load operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| arch/armv7/il.cpp | Added utility functions and VLD1 instruction implementation with register list handling and memory operations |
| arch/armv7/armv7_disasm/armv7.h | Added DoubleWordRegisterList struct definition and formatting cleanup for ieee754_double union |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
add default case for armv7 vld1 unimplemented operand that adds unimplemented instruction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds support for the multiple single elements variant of the vld1 instruction.
A new struct
DoubleWordRegisterListis added to represent register lists and a functionReadRegisterListto read it is added.A utility function
GetDataTypeSizeis also added to return the size of a instruction datatype in bits.A visual comparison of llil before and after.
Before