reduce size of Allocation structs#70
Merged
manon-traverse merged 1 commit intoTraverse-Research:mainfrom Sep 27, 2021
udoprog:allocation-size
Merged
reduce size of Allocation structs#70manon-traverse merged 1 commit intoTraverse-Research:mainfrom udoprog:allocation-size
manon-traverse merged 1 commit intoTraverse-Research:mainfrom
udoprog:allocation-size
Conversation
MarijnS95
approved these changes
Sep 27, 2021
Member
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
Nice to save 8 bytes per-String on the capcity field, these are "immutable" anyway :)
manon-traverse
approved these changes
Sep 27, 2021
Collaborator
manon-traverse
left a comment
manon-traverse
left a comment
There was a problem hiding this comment.
This looks like it makes sense for gpu-allocator. Thank you very much for your contribution! ^.^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the name and backtraces fields on
Allocationto beBox<str>instead ofString, netting us amem::size_of::<Allocation>()decrease from 104 to 88 bytes.Same could be done on
AllocationError, but would be an API break.