Merged
Conversation
Collaborator
Author
|
As discussed in Discord. While this fixes being able to assign numpad keys, AutoSplit still doesn't make the difference between numpad and regular keys. Hitting either will trigger the hotkey. |
ca12d2b to
095855b
Compare
Collaborator
Author
|
Now using hooks. For ease of review, I'll copy new code comments here: |
- Differentiate between numpad and regular numbers - Differentiate between numpad actions and regular actions - Differentiate between numpad actions and numpad numbers - Differentiate dot, numpad dot (or decimal), and delete - Delete and numapd delete won't be cross-compatible if localized in non-english - Used hooks and simplified code
6fd1677 to
6e56367
Compare
Collaborator
Author
|
Uh, just noticed this branch accidentally included the LiveSplit integration, not sure how that happened. Cleaned it up, and retested to be fully working 👍 |
f638624 to
c6601df
Compare
Avasam
referenced
this pull request
in Avasam/AutoSplit
Nov 10, 2021
* Fixed numpad hotkeys - Differentiate between numpad and regular numbers - Differentiate between numpad actions and regular actions - Differentiate between numpad actions and numpad numbers - Differentiate dot, numpad dot (or decimal), and delete - Delete and numapd delete won't be cross-compatible if localized in non-english - Used hooks and simplified code * Fix loading settings with incomplete hotkey configuration * Added Build requirements * Actually send the right event for numpad keys using pyautogui Co-authored-by: KaDiWa4 <kalle.wachsmuth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the numpad hotkeys by getting the key event instead of the name directly. Then checking if it's a keypad event and between [0, 9]. This is necessary because of
keyboard's use of_canonial_names. See: boppreh/keyboard#161 (comment)I've refrained from changing too much here, but the hotkeys module really needs a good refactoring to reduce duplicate code.
Fixes #8
Fixes #25