Skip to content

drivers/sx126x: fail on init if no device is connected#21688

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
fabian18:pr/sx126x_fail_init_without_device
Sep 5, 2025
Merged

drivers/sx126x: fail on init if no device is connected#21688
benpicco merged 1 commit intoRIOT-OS:masterfrom
fabian18:pr/sx126x_fail_init_without_device

Conversation

@fabian18
Copy link
Contributor

@fabian18 fabian18 commented Sep 2, 2025

Contribution description

Fail init() when no sx126x driver is connected.
Else this

assert(false);
assert() triggers for the driver.

Testing procedure

Run DEVELHELP=1 VERBOSE_ASSERT=1 BOARD=adafruit-metro-m4-express USEMODULE+="shell_cmd_ps shield_sx1262" make -C examples/networking/gnrc/gnrc_lorawan flash term PORT=/dev/ttyACM0 with and without a connected device.

Issues/PRs references

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support labels Sep 2, 2025
@crasbe crasbe added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 2, 2025
@riot-ci
Copy link

riot-ci commented Sep 2, 2025

Murdock results

✔️ PASSED

819456c drivers/sx126x: fail on init if no device is connected

Success Failures Total Runtime
10535 0 10536 21m:50s

Artifacts

@benpicco benpicco enabled auto-merge September 5, 2025 09:38
@benpicco benpicco added this pull request to the merge queue Sep 5, 2025
Merged via the queue into RIOT-OS:master with commit 39c68a7 Sep 5, 2025
28 checks passed
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants