tests/sys/events: test if event_timeout_is_pending returns false#21032
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom Nov 26, 2024
Merged
tests/sys/events: test if event_timeout_is_pending returns false#21032mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow merged 1 commit intoRIOT-OS:masterfrom
Conversation
JulianHolzwarth
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
benpicco
added
the
CI: ready for build
mguetschow
requested changes
Nov 25, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks! Just a minor suggestion below.
mguetschow
changed the title
mguetschow
approved these changes
Nov 25, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Looks good! Please squash :)
test if event_timeout_is_pending returns false when event_timeout_t is not completly initialized
JulianHolzwarth
force-pushed
the
pr/tests/events/pending
branch
from
db452b3 to
83cf6bf
Compare
Contributor
Author
|
Squashed and all checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This change edits the /sys/events/ test to test if
event_timeout_is_pendingreturns false whenevent_timeout_tis not completely initialized. Meaning whenevent_timeout_t ->queue,event_timeout_t ->clockorevent_timeout_t ->eventis NULLevent_timeout_is_pendingshould return false.This was previously not tested.
Testing procedure
BOARD=native make -C tests/sys/events flash test