net/dhcpv6: Improve option handling in dhcpv6 advertise#20801
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jul 31, 2024
Merged
net/dhcpv6: Improve option handling in dhcpv6 advertise#20801miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
miri64
approved these changes
Jul 30, 2024
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Looks good. Should there also be similar checks in _parse_advertise()?
Contributor
Author
|
Yes. Those are still missing, I wanted to keep the PRs small as I found the surrounding code rather hard to work with. |
Teufelchen1
added
the
CI: ready for build
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Hello 🐌
This enhances the handling of the option parsing.
Testing procedure
CI should be enough + a good review. Maybe @miri64?
Issues/PRs references