cpu/msp430: improve periph_timer#20160
Merged
maribu merged 4 commits intoRIOT-OS:masterfrom Dec 10, 2023
Merged
Conversation
maribu
added
Type: enhancement
maribu
requested review from
MichelRottleuthner,
MrKevinWeiss,
aabadie,
fjmolinas,
gschorcht,
jia200x,
kaspar030,
leandrolanzieri and
smlng
as code owners
github-actions
bot
added
Area: tests
3 tasks
Member
|
Could this be tested on a different MSP430 board as well? |
Member
Author
Yes, any MSP430 board supported by RIOT has the same two timer peripherals. Only the frequencies the first timer can generate will differ when the CPU clock is different. Note that the tests for the 32.678 kHz timer is taking a couple of seconds due to the slow speed of the timer and the test iterating over three different frequencies the timer claims to support. |
Member
Author
|
Looks like there is still an issue with spurious IRQs on MSP430 F2xx/G2xx:
|
maribu
force-pushed
the
cpu/msp430/timer
branch
from
680e61b to
b501ff2
Compare
Member
Author
No, the test was just buggy 😅 #20161 fixes the issue. |
maribu
added
the
State: waiting for other PR
19 tasks
maribu
force-pushed
the
cpu/msp430/timer
branch
from
b501ff2 to
1c944fc
Compare
maribu
removed
the
State: waiting for other PR
Member
Author
|
Now it works: |
benpicco
approved these changes
Dec 10, 2023
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
I don't have the hardware, but I trust your testing.
Code wise this looks good and is certainly an improvement over the status quo.
- add support for multiple timers
- add support for selecting clock source in the board's `periph_conf.h`
- add support for the prescaler
- implement `periph_timer_query_freqs`
- add a second timer to all MSP430 boards
- the first timer is fast ticking, high-power
- the second is slow ticking, low-power
Declare functions retrieving the clock domains frequency as pure so that common subexpressions can be eliminated more easily.
Move common configuration for MSP430 based boards to `boards/common/msp430` and make use of that.
maribu
force-pushed
the
cpu/msp430/timer
branch
from
1995f4e to
b51ea4c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
|
github-actions
bot
added
Area: tests
Member
Author
|
🎉 Thanks a lot! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
periph_conf.hperiph_timer_query_freqsTesting procedure
make BOARD=olimex-msp430-h1611 flash test -C tests/periph/timerIssues/PRs references
Implements: #16349
Depends on and includes: