cpu/nrf5x_common: clean up UART implementation#20111
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Dec 10, 2023
Merged
Conversation
maribu
added
State: WIP
github-actions
bot
added
Platform: ARM
The functions `uart_poweron()`, `uart_poweroff()` and `uart_mode()` can share code between the UART (UART without EasyDMA) and UARTE (UART with EasyDMA) implementations, so let's do that.
maribu
force-pushed
the
cpu/nrf5x_common/cleanup_uart
branch
from
1a7234a to
659ef97
Compare
Member
Author
|
Using 115200 Bd, 8E1
115200 Bd, 8N1
9600 Bd, 8N1
|
Member
Author
|
Using 9600 Bd, 8N1
115200 Bd, 8E1
115200 Bd, 8N1
|
Member
Author
|
Tested using 9600 Bd, 8N1
115200 BD, 8E1
115200 Bd, 8E2
115200 Bd, 8N1
115200 Bd, 8N2
|
maribu
added
CI: ready for build
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Member
Author
|
Thx :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The functions
uart_poweron(),uart_poweroff()anduart_mode()can share code between the UART (UART without EasyDMA) and UARTE (UART with EasyDMA) implementations, so let's do that.Testing procedure
UART should still work including switching modes - best checked with a logic analyzer attached to verify the output - for:
UARTperipheral (UART without EasyDMA), so any nRF51*UARTEperipheral (UART with EasyDMA) but no support for two stop bits, so e.g. nRF52832UARTEperipheral (UART with EasyDMA) plus support for two stop bits, so e.g. nRF52840 / nRF53 / nRF9160 / ...Issues/PRs references
Follow up to / made possible by #20102