cpu/esp32: fix Octal SPI RAM for ESP32-S3#19957
Merged
bors[bot] merged 3 commits intoRIOT-OS:masterfrom Sep 29, 2023
Merged
Conversation
cf13ff5 to
cb88b86
Compare
benpicco
approved these changes
Sep 29, 2023
Contributor
|
🐙 bors merge |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes Octal SPI RAM handling for ESP32-S3.
Functions that are used during the initialization of the Octal SPI RAM must reside in IRAM instead of Flash. Otherwise, the system stucks during boot once the Octal SPI RAM is enabled. The reason is that the Flash is not available during the initialization of the Octal SPI RAM and the functions that are called during that initialization can't be accessed in Flash. As a result the call of such a function leads to code that is messed up and the system crashes.
The PR also includes the documentation fixe for the
esp32s3-box. It also includes a small documentation fix regarding the SPI RAM for theesp32s3-pros3board.Testing procedure
Use a board that has Octal SPI RAM and flash
tests/sys/malloc, e.g.:Without the PR, the system stuck during boot once the information for the Octal SPI RAM is print
and the board restarts when the watchdog timer expires.
With this PR, the system starts as expected.
Issues/PRs references