Replace __FILE__ and similar with #file or related - breaking change for swift 2.2+#265
Closed
younata wants to merge 1 commit intoQuick:masterfrom
younata:swift2.2
Closed
Replace __FILE__ and similar with #file or related - breaking change for swift 2.2+#265younata wants to merge 1 commit intoQuick:masterfrom younata:swift2.2
younata wants to merge 1 commit intoQuick:masterfrom
younata:swift2.2
Conversation
…for swift 2.2+ Note that as of the most recent (mar 1) swift 3.0 prerelease, there's a compiler bug that this triggers. Might be fixed by next prerelease, might not
Contributor
|
CI doesn't seem to like this so much. If we bump the development snapshot version hopefully it'll fix itself? |
Member
|
As @morganchen12 mentioned, the version of swift referenced via swiftenv needs to be updated to the latest snapshot. Also, I think these changes would force us to maintain a separate branch until Xcode stable has these changes. |
Merged
Member
Author
|
Closing in favor of #269 |
phatblat
pushed a commit
to phatblat/Nimble
that referenced
this pull request
May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey friends! (Hi Jeff! Hi Brian!)
Note that as of the most recent (mar 1) swift 3.0 prerelease, there's a compiler bug that this triggers. Might be fixed by next prerelease, might not. If not, then help would be nice?
A stack trace of the compiler bug, if you're interested: