Skip to content

Comments

fix: remove carpet clean mode#772

Merged
allenporter merged 1 commit intomainfrom
remove_carpet_clean_mode
Feb 22, 2026
Merged

fix: remove carpet clean mode#772
allenporter merged 1 commit intomainfrom
remove_carpet_clean_mode

Conversation

@Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Feb 22, 2026

Carpet Clean mode is not actually a real mode, I misread some of the decompiled app code.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
roborock/data/v1/v1_clean_modes.py 74.31% <ø> (+1.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps
Copy link

greptile-apps bot commented Feb 22, 2026

Greptile Summary

Removed the CARPET vacuum mode (value 107) from the VacuumModes enum and its associated conditional logic in get_clean_modes() that checked features.is_carpet_deep_clean_supported.

Key changes:

  • Deleted CARPET = ("carpet", 107) enum entry from VacuumModes class
  • Removed conditional block that appended VacuumModes.CARPET based on feature flag

The feature flag is_carpet_deep_clean_supported remains defined in device_features.py but is no longer referenced anywhere in the codebase. The removal is clean with no dependencies on the CARPET mode enum value found in tests or other code.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change cleanly removes a mode that was never actually valid. No code references VacuumModes.CARPET, no tests use it, and the only remaining reference is the unused feature flag is_carpet_deep_clean_supported in device_features.py
  • No files require special attention

Important Files Changed

Filename Overview
roborock/data/v1/v1_clean_modes.py Removed non-existent CARPET mode enum value and associated feature check from get_clean_modes()

Last reviewed commit: 213655c

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the previously-added “carpet” suction/fan-power mode from the V1 clean mode enumeration and from the dynamically computed fan speed options, based on updated understanding that it is not a real device mode.

Changes:

  • Removed VacuumModes.CARPET from the VacuumModes enum.
  • Stopped appending the carpet mode to get_clean_modes() based on features.is_carpet_deep_clean_supported.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MAX = ("max", 104)
MAX_PLUS = ("max_plus", 108)
CARPET = ("carpet", 107)
OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109)
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing VacuumModes.CARPET is a breaking public API change (this enum is re-exported from roborock and used by consumers). With the current semantic-release config, a fix: commit will not trigger a major bump, so this could ship as a minor/patch while breaking downstream code. Consider keeping CARPET as a deprecated alias (but omit it from get_clean_modes()), or change the release classification (e.g., refactor) and ensure the breaking change is clearly called out in the changelog.

Suggested change
OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109)
OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109)
# Deprecated: kept as alias for backward compatibility with older public API
CARPET = OFF

Copilot uses AI. Check for mistakes.
@allenporter allenporter merged commit 931b68e into main Feb 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants