Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Greptile SummaryRemoved the Key changes:
The feature flag Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 213655c |
There was a problem hiding this comment.
Pull request overview
Removes the previously-added “carpet” suction/fan-power mode from the V1 clean mode enumeration and from the dynamically computed fan speed options, based on updated understanding that it is not a real device mode.
Changes:
- Removed
VacuumModes.CARPETfrom theVacuumModesenum. - Stopped appending the carpet mode to
get_clean_modes()based onfeatures.is_carpet_deep_clean_supported.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MAX = ("max", 104) | ||
| MAX_PLUS = ("max_plus", 108) | ||
| CARPET = ("carpet", 107) | ||
| OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109) |
There was a problem hiding this comment.
Removing VacuumModes.CARPET is a breaking public API change (this enum is re-exported from roborock and used by consumers). With the current semantic-release config, a fix: commit will not trigger a major bump, so this could ship as a minor/patch while breaking downstream code. Consider keeping CARPET as a deprecated alias (but omit it from get_clean_modes()), or change the release classification (e.g., refactor) and ensure the breaking change is clearly called out in the changelog.
| OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109) | |
| OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109) | |
| # Deprecated: kept as alias for backward compatibility with older public API | |
| CARPET = OFF |
Carpet Clean mode is not actually a real mode, I misread some of the decompiled app code.