Rename variety sprites to correct Pokémon IDs#198
Merged
Naramsim merged 3 commits intoPokeAPI:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
Author
|
I’ve run the rename script on two folders so far: |
Naramsim
reviewed
Feb 27, 2026
scripts/rename_pokemon_varieties.py
Outdated
| new_path = os.path.join(root, new_filename) | ||
|
|
||
| # Prevent overwriting if the file already exists | ||
| # if not os.path.exists(new_path): |
Member
There was a problem hiding this comment.
Why is this part commented? When a file is already present we could simply delete the id-variant.png file.
Contributor
Author
There was a problem hiding this comment.
I commented this out so the file is always renamed, which lets me double-check any differences between the id-variant and the Pokémon ID. The id-variant file is always deleted.
Contributor
There was a problem hiding this comment.
I think there should be a case when there is a id-<variant> and a new custom <id> (10000+) present we compare both the images if they are same either rename or delete but if its different we flag that somewhere
Naramsim
reviewed
Feb 27, 2026
anhthang
force-pushed
the
rename-images
branch
from
6734f32 to
6d3db1d
Compare
FallenDeity
reviewed
Feb 28, 2026
FallenDeity
reviewed
Feb 28, 2026
FallenDeity
reviewed
Feb 28, 2026
Contributor
Author
|
@FallenDeity thanks for your suggestions, script updated |
Member
|
Alright, thanks a lot @anhthang for the contribution and @FallenDeity for the much appreciated review! |
Naramsim
approved these changes
Mar 2, 2026
Member
|
Now you can run the script on a single folder and create another PR. Then we'll do all the folders altogether. |
This was referenced Mar 3, 2026
Contributor
Author
I've made 3 PRs for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a script that renames variety PNG files (e.g. 877-hangry.png) to their correct Pokémon IDs by querying the Pokémon species endpoint and matching varieties by name.
Resolves #174.
First run against the official-artwork folder looks correct; I'll follow up with 2–3 other folders in this PRs and keep this minimal.