Merged
Conversation
stevencl840
force-pushed
the
sjc/update-build-process
branch
from
1ca2217 to
cf91cb2
Compare
|
Minor organizational request. Can we create a PR back into the upstream branch for the mac change so that we can drop this diff if/when they update. |
zentron
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context 🌆
We recently needed to make changes to our fork of libgit2sharp, and found the build process was not working. This PR fixes the build process.
Details 🔍
There are two main parts to this
Remove .NET 6.0 support
.Net6.0 support was reintroduced in "Re-introduce .net6 while we still have Calamari running in .net6". Since then, Calamari has updated to .NET 8 and removed support for .NET 6.0(here) . As such, we can nwt remove support for .NET 6 from this project.
MacOS-13 is a retired runner
Macintosh OS 13 has been retired as a runner for GitHub Actions. This prevents the macOS tests from running successfully. I have updated the OS for these tests to macOS-14, and it now runs successfully.
Ideally, this would be a PR that we could submit for the main fork
Unfortunately, without both these changes, I cannot get a green build. In order to merge either of them, I need to include both. The macOS update should be all that is required by the parent fork. They already do not support .NET 6. I will not squash these two commits in this PR. I will then create a separate standalone PR with macOS change for the parent fork.
[sc-131120]