Do not use string formatting LibGit2SharpException constructor#10
Merged
dylanlerch merged 1 commit intooctopus/masterfrom Nov 2, 2022
Merged
Conversation
dylanlerch
force-pushed
the
dylan/fix-exception-format-error
branch
from
21ad1af to
1d53378
Compare
…uilding unknown exception types
The exception constructors in GitErrorsToLibGit2SharpExceptions make use of the error category by passing it through to the NativeException(string message, GitErrorCategory category) constructor which adds ("libgit2.category", category) to Data on System.Exception.
We were calling new LibGit2SharpException(m, c), but this was resolving to the string formatting constructor on LibGit2SharpException, because it does not have a constructor that takes a category. This runs a string format, so if the errorMessage contained any curly braces, that constructor would throw an System.FormatException.
This has been changed to just use the message constructor (with no format arguments), and will drop the error code (which is always Unknown anyway).
dylanlerch
force-pushed
the
dylan/fix-exception-format-error
branch
from
1d53378 to
16435c2
Compare
This was referenced Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception constructors in
GitErrorsToLibGit2SharpExceptionsmake use of the error category by passing it through to theNativeException(string message, GitErrorCategory category)constructor which adds("libgit2.category", category)toDataonSystem.Exception.We were calling new
LibGit2SharpException(m, c), but this was resolving to the string formatting constructor on LibGit2SharpException, because it does not have a constructor that takes a category. This runs a string format, so if theerrorMessagecontained any curly braces, that constructor would throw anSystem.FormatException.This has been changed to just use the message constructor (with no format arguments), and will drop the error code (which is always Unknown anyway)