Merged
Conversation
Filter on "real"/user documents (no odoo assets), filter on res_model, filter on indexed content.
pedrobaeza
reviewed
Dec 23, 2016
knowledge/__manifest__.py
Outdated
| "depends": ["base_setup"], | ||
| "author": "OpenERP SA, Odoo Community Association (OCA)", | ||
| "category": "Hidden/Dependency", | ||
| "version": "10.0.1.1.0", |
max3903
requested changes
Jan 5, 2017
knowledge/__manifest__.py
Outdated
| "author": "OpenERP SA, Odoo Community Association (OCA)", | ||
| "category": "Hidden/Dependency", | ||
| "version": "10.0.1.1.0", | ||
| "author": "MONK Software, Odoo Community Association (OCA)", |
knowledge/__manifest__.py
Outdated
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ############################################################################## | ||
| # Copyright 2016 MONK Software |
| 'Store attachments in an external DMS instead of the Odoo Filestore', | ||
| help='Connect Odoo with a CMIS compatible server to store files.\n' | ||
| '- This installs the module cmis_write.' | ||
| ) |
Member
There was a problem hiding this comment.
@LeartS Please keep those fields. Even if the modules are not migrated, it gives them visibility.
Member
There was a problem hiding this comment.
Maybe make them readonly until they are ported?
dreispt
reviewed
Jan 6, 2017
| 'Store attachments in an external DMS instead of the Odoo Filestore', | ||
| help='Connect Odoo with a CMIS compatible server to store files.\n' | ||
| '- This installs the module cmis_write.' | ||
| ) |
Member
There was a problem hiding this comment.
Maybe make them readonly until they are ported?
| @@ -1,3 +0,0 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_ir_attachment_sale_manager,ir_attachment manager,base.model_ir_attachment,base.group_sale_manager,1,1,1,1 | |||
| access_ir_attachment_partner_manager,ir_attachment_partner manager,base.model_ir_attachment,base.group_partner_manager,1,1,1,1 | |||
Contributor
Author
There was a problem hiding this comment.
Because:
- the groups didn't make any sense; why should attachments be restricted to sale managers and partner managers?
- the
base.group_sale_managergroup doesn't exist anymore, it has been moved to thesales_teammodule. I don't see why theknowledgemodule should depend onsales_team - attachments already implement a custom logic for permissions: attachments linked to a record (so, all "user" attachments, which are the main focus of this module) can be accessed by the same people who can access the linked record. That logic is much better and in my opinion, sufficient.
[FIX] Copyright and various stuff
Member
|
@LeartS will you address my comments? |
max3903
approved these changes
Jan 13, 2017
dreispt
approved these changes
Jan 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.