Merged
Conversation
Contributor
Author
|
@rigor789 / @NathanWalker can we get this reviewed, merged and a new version of the JSC runtime pushed over to NPM. Have an app that I need to build against latest SDKs. |
rigor789
approved these changes
Sep 21, 2022
Member
rigor789
left a comment
rigor789
left a comment
There was a problem hiding this comment.
lgtm, will try to get this published by eod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
App using the JSC fails to compile using XCode14
What is the new behavior?
Fixes app build with Xcode 14.
Changes taken from NativeScript/ios@3b1eafc
Fixes/Implements/Closes #[Issue Number].