Merged
Conversation
…s.py identical to main (this diff looks like an accident or oversight).
… to main (this diff looks like an accident or oversight).
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test c45609c |
Collaborator
Author
|
/ok to test bc18d8a |
This comment has been minimized.
This comment has been minimized.
leofang
added
P0
Member
|
/ok to test 4159eb2 |
Member
|
/ok to test 84cf3a0 |
Member
|
The Windows test failure is explained in #599. |
leofang
force-pushed
the
rebase_to_ctk_12.9
branch
from
84cf3a0 to
58837f2
Compare
Contributor
Member
|
/ok to test 58837f2 |
Member
|
/ok to test bec052f |
leofang
reviewed
May 3, 2025
Member
|
/ok to test d2db7a6 |
Member
|
Once #600 is green/merged we can rerun the failing test to make all CI pipelines happy. |
Collaborator
Author
|
/ok to test bcc950e |
Collaborator
Author
|
@leofang @vzhurba01 All tests pass now (thanks to #600). When do we want to merge this? |
leofang
approved these changes
May 4, 2025
Member
|
Anytime! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #589.