Allow passing a cause to predefined error functions#83
Merged
Conversation
This allows passing an `Error` class object to one of the predefined error functions as defined in `rpcErrors` and `providerErrors`. Upon calling the `serialise` function of the `JsonRpcError` class, the cause error will be serialised using the `serializeCause` function.
The expect function ensures that the type of error.serialize().data is an object and contains specific serialized data while ensuring it does not contain an error instance. This test is necessary to avoid unexpected errors during exception handling.
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
FrederikBolding
approved these changes
Apr 17, 2023
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows passing an
Errorclass object to one of the predefined error functions as defined inrpcErrorsandproviderErrors. Upon calling theserialisefunction of theJsonRpcErrorclass, the cause error will be serialised using theserializeCausefunction.For example:
Callng
error.serialize()results in:{ "code": -32602, "message": "Invalid method parameter(s).", "data": { "cause": { "stack": "Error: foo bar [...]", "message": "foo bar" } }, "stack": "Error: Invalid method parameter(s). [...]" }