This repository was archived by the owner on Oct 7, 2024. It is now read-only.
feat: make the KeyringAccount type "abstract"#311
Merged
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
danroc
force-pushed
the
feature/abstract-account
branch
2 times, most recently
from
3390a2d to
5f2bc8c
Compare
This was referenced May 22, 2024
danroc
force-pushed
the
feature/abstract-account
branch
from
5132914 to
e63451a
Compare
ccharly
reviewed
May 23, 2024
danroc
force-pushed
the
feature/abstract-account
branch
2 times, most recently
from
57d957e to
736450e
Compare
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
danroc
force-pushed
the
feature/abstract-account
branch
from
736450e to
0d414bf
Compare
ccharly
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially reverts the work of splitting the
KeyringAccounttype into blockchain specific types. This is useful to facilitate the integration of new blockchains in the future.Fixes: https://github.com/MetaMask/accounts-planning/issues/455