This repository was archived by the owner on Oct 7, 2024. It is now read-only.
feat: add display confirmation option to AccountCreatedEvent#307
Merged
Conversation
danroc
reviewed
May 16, 2024
danroc
reviewed
May 16, 2024
danroc
reviewed
May 16, 2024
Co-authored-by: Daniel Rocha <daniel.rocha@consensys.net>
ccharly
reviewed
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the option to
displayConfirmationto theAccountCreatedEventStructIn the future, all preinstalled snaps will not go through the add account confirmation flow. However, this will be necessary not to bypass the add account confirmation screens for certain preinstalled snap scenarios (Bitcoin snap in portfolio).