This repository was archived by the owner on Oct 7, 2024. It is now read-only.
feat: add accountNameSuggestion field to the AccountCreatedEvent#291
Merged
feat: add accountNameSuggestion field to the AccountCreatedEvent#291
accountNameSuggestion field to the AccountCreatedEvent#291Conversation
053b190 to
94915fc
Compare
Contributor
Author
|
Converting to draft to explore the idea of including the account name suggestion in the Snap's manifest. |
94915fc to
b6bad6d
Compare
b6bad6d to
487b4cc
Compare
k-g-j
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
accountNameSuggestionfield to theAccountCreatedEventto allow the keyring (Snap) to make a suggestion for how the account should be named.MetaMask is responsible for allowing the user to accept or modify the proposed name.
Examples
The Snap can call: