Skip to content

Align types with @metamask/eth-json-rpc-provider #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 1 commit into from
Nov 9, 2023
Merged

Align types with @metamask/eth-json-rpc-provider #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ declare module '@metamask/eth-query' {
| symbol
| undefined;

type Json =
| null
| boolean
| number
| string
| Json[]
| { [prop: string]: Json };

type JsonRpcParams = Json[] | Record<string, Json>;

type ProviderSendAsyncResponse<Result> = {
error?: { message: string };
result?: Result;
Expand All @@ -21,13 +31,13 @@ declare module '@metamask/eth-query' {
) => void;

type Provider = {
sendAsync<Params, Result>(
sendAsync<Params extends JsonRpcParams, Result>(
payload: SendAsyncPayload<Params>,
callback: ProviderSendAsyncCallback<Result>,
): void;
};

type SendAsyncPayload<Params> = {
type SendAsyncPayload<Params extends JsonRpcParams> = {
id: number;
jsonrpc: '2.0';
method: string;
Expand All @@ -43,7 +53,7 @@ declare module '@metamask/eth-query' {
export default class EthQuery {
constructor(provider: Provider);

sendAsync<Params, Result>(
sendAsync<Params extends JsonRpcParams, Result>(
opts: Partial<SendAsyncPayload<Params>>,
callback: SendAsyncCallback<Result>,
): void;
Expand Down