feat(transaction-pay): add Across strategy support by pedronfigueiredo · Pull Request #7886 · MetaMask/core

pedronfigueiredo · 2026-02-10T11:23:47Z

Explanation

This PR extracts the Across strategy work on top of the provider-fallback baseline.

It adds:

Across strategy wiring (across strategy type + registration)
Across quote retrieval/parsing/normalization
Across submit flow for approval + swap/deposit execution paths
Across-specific types/constants required for compilation
Minimal selection/config hooks to make Across selectable
Changelog entries for transaction-controller and transaction-pay-controller

References

Addresses: https://github.com/MetaMask/MetaMask-planning/issues/6997

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Adds a new on-chain submission path that builds/sends approval and deposit transactions and introduces external API polling, so failures could impact transaction execution and fee/gas calculations. Feature-flag gating and extensive tests reduce but don’t eliminate integration risk.

Overview
Adds a new Across transaction-pay strategy and makes it part of the default strategy order/selection, with feature-flagged enablement and strategy-specific config (apiBase, integratorId, allowSameChain, postActionsEnabled).

Implements Across quote retrieval/normalization and submission: calls Across /swap/approval with optional MetaMask app-fee params and optional post-actions, estimates gas with buffering and fallbacks, submits approval+deposit as a batch (or a single deposit), marks intents complete, tracks required transaction IDs, and optionally polls Across /deposit/status to return the destination/fill hash.

Extends shared types/utilities to support this flow (new TransactionPayAction structure, getPayStrategiesConfig, shared sumAmounts/getFiatValueFromUsd, and a reusable estimateGasLimitWithBufferOrFallback), updates Relay’s supports gating, and introduces new TransactionTypes (perpsAcrossDeposit, predictAcrossDeposit) with changelog entries.

^{Written by Cursor Bugbot for commit 3c7fd02. This will update automatically on new commits. Configure here.}

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

packages/transaction-pay-controller/src/strategy/across/types.ts

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

matthewwalsh0 · 2026-02-13T22:48:19Z

packages/transaction-pay-controller/src/utils/gas.ts

+  return getFeatureFlags(messenger).relayFallbackGas;
+}
+
+export async function estimateGasWithBufferOrFallback({


estimateGasLimit?

matthewwalsh0 · 2026-02-13T22:48:34Z

packages/transaction-pay-controller/src/utils/gas.ts

  };
 }

+export function getFallbackGas(messenger: TransactionPayControllerMessenger): {


Should this be in feature-flags.ts?

matthewwalsh0 · 2026-02-13T22:49:54Z

packages/transaction-pay-controller/src/utils/gas.ts

+    error = caughtError;
+  }
+
+  const fallbackGas = getFallbackGas(messenger);


Debatable whether we should have fallback gas or throw as it implies the transaction would revert?

fallback is now option but off by default

matthewwalsh0 · 2026-02-13T22:51:46Z

packages/transaction-pay-controller/src/utils/feature-flags.ts

+  across?: PayStrategyConfigRaw;
+  relay?: {
+    enabled?: boolean;
+    relayQuoteUrl?: string;


Is this redundant as we already have the top level value?

matthewwalsh0 · 2026-02-13T22:52:54Z

packages/transaction-pay-controller/src/utils/feature-flags.ts

  slippage: number;
 };

+export type PayStrategyConfigRaw = {


Should this be AcrossConfig?

matthewwalsh0 · 2026-02-13T23:25:24Z

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

+    messenger,
+  });
+
+  const max = calculateGasCost({


We also need gas station support here, but can do that in a future PR and re-use the Relay logic.

added a ticket for this

matthewwalsh0 · 2026-02-13T23:32:15Z

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

+  request: QuoteRequest,
+): Promise<TransactionPayQuote<AcrossQuote>['fees']['sourceNetwork']> {
+  const { from } = request;
+  const { swapTx } = quote;


Do we also need to include gas cost of approvalTxns?

matthewwalsh0 · 2026-02-13T23:34:19Z

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

+  const chainId = toHex(params.chainId);
+  const value = toHex(params.value ?? '0x0');
+
+  const gas = await estimateGasWithBuffer(


We don't want to duplicate the gas logic again, but store the gas limits in the quote to use during submit, so we know the network fees will match.

matthewwalsh0 · 2026-02-13T23:34:50Z

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

+    data: params.data,
+    from,
+    gas: toHex(gas),
+    maxFeePerGas: normalizeOptionalHex(params.maxFeePerGas),


Can they not return gas fee properties?

not sure I understand the question here, it's simply normalising to hex if needed.

matthewwalsh0 · 2026-02-13T23:37:05Z

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

+  }
+
+  await Promise.all(
+    transactionIds.map((txId) => waitForTransactionConfirmed(txId, messenger)),


We're waiting for the deposit transactions to succeed, but we also need to poll the Across API to verify the status of their transactions on the target chain.

Looks like /deposit/status?

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

packages/transaction-pay-controller/src/strategy/across/types.ts

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

packages/transaction-pay-controller/src/strategy/across/across-submit.ts

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts

packages/transaction-pay-controller/src/utils/feature-flags.ts

packages/transaction-pay-controller/src/utils/gas.ts

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

packages/transaction-pay-controller/src/strategy/across/types.ts

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

cursor · 2026-02-25T13:35:08Z

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts

+
+    if (request.transaction?.type === TransactionType.perpsAcrossDeposit) {
+      return false;
+    }


Missing predictAcrossDeposit guard causes potential recursion

High Severity

The supports() guard only rejects TransactionType.perpsAcrossDeposit but not TransactionType.predictAcrossDeposit. Since getAcrossDepositType maps predictDeposit → predictAcrossDeposit, the Across strategy will incorrectly consider its own predict-type deposit transactions as eligible, potentially causing recursive re-processing.

Additional Locations (1)

packages/transaction-pay-controller/src/strategy/across/across-submit.ts#L318-L332

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts

pedronfigueiredo self-assigned this Feb 10, 2026

pedronfigueiredo requested review from a team as code owners February 10, 2026 11:23

pedronfigueiredo added the team-confirmations label Feb 10, 2026

cursor bot reviewed Feb 10, 2026

View reviewed changes

pedronfigueiredo force-pushed the cor-6997-across-strategy branch 2 times, most recently from 665488f to 8be8f8c Compare February 10, 2026 12:09

cursor bot reviewed Feb 10, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 8be8f8c to 3f52702 Compare February 10, 2026 12:27

cursor bot reviewed Feb 10, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-submit.ts Outdated Show resolved Hide resolved

packages/transaction-pay-controller/src/strategy/across/across-submit.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 3f52702 to 789a704 Compare February 10, 2026 13:46

cursor bot reviewed Feb 10, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-submit.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 789a704 to 6953629 Compare February 10, 2026 14:20

cursor bot reviewed Feb 10, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 6953629 to 8c1c7e5 Compare February 10, 2026 16:31

pedronfigueiredo added the DO-NOT-MERGE label Feb 11, 2026

pedronfigueiredo force-pushed the cor-6992-extract-fallback-mechanism branch 4 times, most recently from 9cd0f37 to a6c9af9 Compare February 13, 2026 10:47

matthewwalsh0 requested changes Feb 13, 2026

View reviewed changes

pedronfigueiredo force-pushed the cor-6992-extract-fallback-mechanism branch 4 times, most recently from 08bac6a to 26c090a Compare February 16, 2026 10:51

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 8c1c7e5 to 68679f6 Compare February 16, 2026 12:20

cursor bot reviewed Feb 16, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Show resolved Hide resolved

cursor bot reviewed Feb 16, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-submit.ts Show resolved Hide resolved

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 0df61f2 to 43816bc Compare February 16, 2026 17:55

cursor bot reviewed Feb 16, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/types.ts Outdated Show resolved Hide resolved

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from e9f21d7 to bc1b4fe Compare February 23, 2026 14:17

cursor bot reviewed Feb 23, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from bc1b4fe to a2cec3d Compare February 23, 2026 15:05

cursor bot reviewed Feb 23, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-submit.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from a2cec3d to 4e7659a Compare February 23, 2026 15:32

cursor bot reviewed Feb 23, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Show resolved Hide resolved

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts Show resolved Hide resolved

packages/transaction-pay-controller/src/utils/feature-flags.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 4e7659a to 3c6deb7 Compare February 23, 2026 16:59

cursor bot reviewed Feb 23, 2026

View reviewed changes

packages/transaction-pay-controller/src/utils/gas.ts Show resolved Hide resolved

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 3c6deb7 to d514937 Compare February 23, 2026 17:26

cursor bot reviewed Feb 23, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/types.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from d514937 to b78255e Compare February 24, 2026 09:47

cursor bot reviewed Feb 24, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/types.ts Outdated Show resolved Hide resolved

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Outdated Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from b78255e to bbcb0e4 Compare February 24, 2026 10:37

cursor bot reviewed Feb 24, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/across-quotes.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from bbcb0e4 to 9d2e07b Compare February 24, 2026 14:58

cursor bot reviewed Feb 24, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts Show resolved Hide resolved

pedronfigueiredo requested a review from matthewwalsh0 February 24, 2026 17:13

pedronfigueiredo force-pushed the cor-6997-across-strategy branch 2 times, most recently from 303f7d7 to d1799f1 Compare February 25, 2026 12:12

cursor bot reviewed Feb 25, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from d1799f1 to 239eab7 Compare February 25, 2026 13:23

cursor bot reviewed Feb 25, 2026

View reviewed changes

pedronfigueiredo force-pushed the cor-6997-across-strategy branch 2 times, most recently from 78893dc to 0680f84 Compare February 25, 2026 13:50

cursor bot reviewed Feb 25, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts Show resolved Hide resolved

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 0680f84 to 5fd161f Compare February 25, 2026 14:05

cursor bot reviewed Feb 25, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts Show resolved Hide resolved

feat(transaction-pay): add Across strategy support

3c7fd02

pedronfigueiredo force-pushed the cor-6997-across-strategy branch from 5fd161f to 3c7fd02 Compare February 25, 2026 14:20

cursor bot reviewed Feb 25, 2026

View reviewed changes

packages/transaction-pay-controller/src/strategy/across/AcrossStrategy.ts Show resolved Hide resolved

Uh oh!

Conversation

pedronfigueiredo commented Feb 10, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 25, 2026

Choose a reason for hiding this comment

Missing predictAcrossDeposit guard causes potential recursion

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

pedronfigueiredo commented Feb 10, 2026 •

edited by cursor bot

Loading

Missing `predictAcrossDeposit` guard causes potential recursion