Merged
Conversation
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
from
7d1d9a6 to
9ad143c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
make-rollback-to-previous-provider-async
branch
from
0415411 to
948e8ae
Compare
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
from
9ad143c to
92d373a
Compare
Gudahtt
force-pushed
the
make-rollback-to-previous-provider-async
branch
from
948e8ae to
7f401cd
Compare
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
from
eb4fae4 to
4e1f13c
Compare
Gudahtt
force-pushed
the
make-rollback-to-previous-provider-async
branch
from
7f401cd to
7d838f2
Compare
Base automatically changed from
update-eip-1559-compatibility-during-network-lookup
to
main
April 21, 2023 13:27
The network controller method `rollbackToPreviousProvider` has been made async. This method used to switch back to the previous network without waiting for the network switch operation to complete. Now it will not resolve until the switch has completed. Relates to #1176
Gudahtt
force-pushed
the
make-rollback-to-previous-provider-async
branch
from
7d838f2 to
ed71ed8
Compare
mcmire
reviewed
Apr 21, 2023
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
A couple things, but otherwise looks good.
| }); | ||
|
|
||
| await waitForStateChanges(messenger, { | ||
| propertyPath: ['networkId'], |
Contributor
There was a problem hiding this comment.
Thank you! I must have missed this when I wrote it.
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Make `rollbackToPreviousProvider` async The network controller method `rollbackToPreviousProvider` has been made async. This method used to switch back to the previous network without waiting for the network switch operation to complete. Now it will not resolve until the switch has completed. Relates to #1176 * Add missing "before"
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Make `rollbackToPreviousProvider` async The network controller method `rollbackToPreviousProvider` has been made async. This method used to switch back to the previous network without waiting for the network switch operation to complete. Now it will not resolve until the switch has completed. Relates to #1176 * Add missing "before"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The network controller method
rollbackToPreviousProviderhas been made async. This method used to switch back to the previous network without waiting for the network switch operation to complete. Now it will not resolve until the switch has completed.Changes
rollbackToPreviousProvideris now asyncReferences
Closes #1176
Fixes #1178
Checklist